Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerized CI and expansion to trigger external tests #51

Merged
merged 64 commits into from
Jul 11, 2024

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Jun 5, 2024

Description
In this PR, the CI workflow is changed to run in a container. The image is built from a base miniforge image. GNU compilers, netCDF and HDF5 libraries, and MPICH have been installed. The default python version is set to 3.11.7.

Files fv3_translate_tests.yaml, pace_tests.yaml, and shield_tests.yaml have been added to run the CI workflow in to test NDSL changes in pyFV3, pace, and pySHiELD.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@fmalatino fmalatino mentioned this pull request Jun 11, 2024
@mlee03 mlee03 marked this pull request as ready for review June 12, 2024 14:57
@mlee03 mlee03 changed the title Containerized CI and expansion to trigger fv3 translate tests Containerized CI and expansion to trigger external tests Jun 24, 2024
@mlee03
Copy link
Contributor Author

mlee03 commented Jun 24, 2024

I apologize to everyone, I decided to push reusable workflow changes to this existing PR, the PR has changed since last perusal.

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After conflicts are resolved, good to merge

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be reviewed after PR 25 in pyFV3

Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmalatino fmalatino merged commit cbe983d into NOAA-GFDL:develop Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants