Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pressure coeff to be read from ak & bk data #34

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Apr 13, 2024

Description
In order to facilitate integration with existing model, we allow the pressure coefficients AK/BK to be read from data. We keep the same checks and give precedence to the data to keep backward compatibility.

How Has This Been Tested?
Tested on GEOS integration. No unit test present but default behavior did not change.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@FlorianDeconinck
Copy link
Collaborator Author

PR died because of mpi4py build failing on the setup side of things, will investigate.

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FlorianDeconinck FlorianDeconinck merged commit 3ab2cff into develop Apr 17, 2024
3 checks passed
@FlorianDeconinck FlorianDeconinck deleted the feature/eta_from_data branch April 17, 2024 13:03
This was referenced Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants