Changes requested 1000 7 Mar 2024, PR 14 from Florian

NOAA-GFDL · Mar 7, 2024 · a40a026 · a40a026
1 parent 9f0477a
commit a40a026
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 7 deletions.
diff --git a/ndsl/checkpointer/__init__.py b/ndsl/checkpointer/__init__.py
@@ -1,5 +1,5 @@
 from .null import NullCheckpointer
-from .snapshots import SnapshotCheckpointer, _Snapshots
+from .snapshots import SnapshotCheckpointer
 from .thresholds import (
  InsufficientTrialsError,
  SavepointThresholds,

diff --git a/ndsl/comm/__init__.py b/ndsl/comm/__init__.py
@@ -4,6 +4,5 @@
  CachingCommWriter,
  CachingRequestReader,
  CachingRequestWriter,
- NullRequest,
 )
 from .comm_abc import Comm, Request
diff --git a/ndsl/comm/communicator.py b/ndsl/comm/communicator.py
@@ -54,7 +54,7 @@ def __init__(
  self.timer: Timer = timer if timer is not None else NullTimer()
 
  @abc.abstractproperty
- def tile(self):
+ def tile(self) -> "TileCommunicator":
  pass
 
  @classmethod

diff --git a/ndsl/dsl/stencil.py b/ndsl/dsl/stencil.py
@@ -32,8 +32,6 @@
 from ndsl.dsl.typing import Float, Index3D, cast_to_index3d
 from ndsl.initialization.sizer import GridSizer, SubtileGridSizer
 from ndsl.quantity import Quantity
-
-# from ndsl import testing
 from ndsl.testing import comparison
 
 

diff --git a/tests/checkpointer/__init__.py b/tests/checkpointer/__init__.py
diff --git a/tests/dsl/__init__.py b/tests/dsl/__init__.py
diff --git a/tests/dsl/test_stencil_wrapper.py b/tests/dsl/test_stencil_wrapper.py
@@ -285,14 +285,14 @@ def test_backend_options(
  "backend": "numpy",
  "rebuild": True,
  "format_source": False,
- "name": "tests.dsl.test_stencil_wrapper.copy_stencil",
+ "name": "test_stencil_wrapper.copy_stencil",
  },
  "cuda": {
  "backend": "cuda",
  "rebuild": True,
  "device_sync": False,
  "format_source": False,
- "name": "tests.dsl.test_stencil_wrapper.copy_stencil",
+ "name": "test_stencil_wrapper.copy_stencil",
  },
  }
 

diff --git a/tests/quantity/__init__.py b/tests/quantity/__init__.py