Enable prescribed ice for UFS #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrianCurtis-NOAA @DeniseWorthen could you please review this CICE PR? |
NickSzapiro-NOAA
changed the title
@DeniseWorthen If this is ready for PR to CICE-Consortium, do you want me to do that (now)? |
|
@DeniseWorthen @NickSzapiro-NOAA ufs-community/ufs-weather-model#2186 is ready to test. Please, go ahead for final review and approval. |
DeniseWorthen
approved these changes
Jun 10, 2024
junwang-noaa
approved these changes
Jun 10, 2024
|
Testing on #2186 has completed successfully, please continue with merging this PR. |
NickSzapiro-NOAA
added a commit
to NickSzapiro-NOAA/CICE
that referenced
this pull request
Aug 2, 2024
* Remove #ifdef CESMCOUPLED from cicecore/drivers/nuopc/cmeps/CICE_RunMod.F90 * Remove #ifdef CESMCOUPLED from cicecore/drivers/nuopc/cmeps/ice_prescribed_mod.F90 * Testing changing stream_taxmode from cycle to extend * Change include mpif.h to use mpi in ice_prescribed_mod.F90 * Call dshr_pio_init from ice_prescribed_init * Call ice_prescribed_run after ice_prescribed_init * Incorporate ice_prescribed_nml in ice_prescribed_mod.F90 * write stream_taxmode to log. typo in ice_prescribed_mod.F90. * Remove CESMCOUPLED so models initialize ice_prescribed at end of ice_prescribed_init * Change indent for #ifndef for gnu debug * Only call ice_prescribed_run in ice_prescribed_init #ifndef CESMCOUPLED
NickSzapiro-NOAA
added a commit
that referenced
this pull request
Sep 9, 2024
Prescribed ice CICE was enclosed by #ifdef CESMCOUPLED in CMEPS driver. This allows use of prescribed ice CICE in ufs-weather-model with CDEPS calls to input (sea ice concentration) from file. Starting as cherry-picked as in UFS but dependency on CDEPS likely needs to be optional at compile time. This is needed for History conflicts between CICE-Consortium and emc/develop #84 * Enable prescribed ice for UFS (#80) * Remove #ifdef CESMCOUPLED from cicecore/drivers/nuopc/cmeps/CICE_RunMod.F90 * Remove #ifdef CESMCOUPLED from cicecore/drivers/nuopc/cmeps/ice_prescribed_mod.F90 * Testing changing stream_taxmode from cycle to extend * Change include mpif.h to use mpi in ice_prescribed_mod.F90 * Call dshr_pio_init from ice_prescribed_init * Call ice_prescribed_run after ice_prescribed_init * Incorporate ice_prescribed_nml in ice_prescribed_mod.F90 * write stream_taxmode to log. typo in ice_prescribed_mod.F90. * Remove CESMCOUPLED so models initialize ice_prescribed at end of ice_prescribed_init * Change indent for #ifndef for gnu debug * Only call ice_prescribed_run in ice_prescribed_init #ifndef CESMCOUPLED * Note CDEPS dependency in cicecore/drivers/nuopc/cmeps/ice_prescribed_mod.F90 * Remove stub prescribed ice code
NickSzapiro-NOAA
added a commit
that referenced
this pull request
Sep 25, 2024
Prescribed ice CICE was enclosed by #ifdef CESMCOUPLED in CMEPS driver. This allows use of prescribed ice CICE in ufs-weather-model with CDEPS calls to input (sea ice concentration) from file. Starting as cherry-picked as in UFS but dependency on CDEPS likely needs to be optional at compile time. This is needed for History conflicts between CICE-Consortium and emc/develop #84 * Enable prescribed ice for UFS (#80) * Remove #ifdef CESMCOUPLED from cicecore/drivers/nuopc/cmeps/CICE_RunMod.F90 * Remove #ifdef CESMCOUPLED from cicecore/drivers/nuopc/cmeps/ice_prescribed_mod.F90 * Testing changing stream_taxmode from cycle to extend * Change include mpif.h to use mpi in ice_prescribed_mod.F90 * Call dshr_pio_init from ice_prescribed_init * Call ice_prescribed_run after ice_prescribed_init * Incorporate ice_prescribed_nml in ice_prescribed_mod.F90 * write stream_taxmode to log. typo in ice_prescribed_mod.F90. * Remove CESMCOUPLED so models initialize ice_prescribed at end of ice_prescribed_init * Change indent for #ifndef for gnu debug * Only call ice_prescribed_run in ice_prescribed_init #ifndef CESMCOUPLED * Note CDEPS dependency in cicecore/drivers/nuopc/cmeps/ice_prescribed_mod.F90 * Remove stub prescribed ice code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Enable prescribed ice CICE for UFS via CMEPS driver
Nicholas Szapiro & Denise Worthen
New ufs-weather-model regression test atm_ds2s_docn_pcice (Add active atmosphere applications with data ocn and data ice components (ATM_DS2S and ATM_DS2S-PCICE) and regression tests (atm_ds2s_docn_dice and atm_ds2s_docn_pcice) ufs-community/ufs-weather-model#2186)
Prescribed ice CICE was enclosed by #ifdef CESMCOUPLED in CMEPS driver. This (with UWM PR) enables the capability to use prescribed ice CICE in ufs-weather-model with CDEPS calls to input from file.