Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values of fates_hydro_solver and fates_hydro_vg_alpha_node #1263

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jennykowalcz
Copy link

@jennykowalcz jennykowalcz commented Oct 14, 2024

This PR changes the default values of the parameters fates_hydro_solver and fates_hydro_vg_alpha_node.

Description:

The default for hydro_solver is changed from 1 (Taylor 1D) to 2 (Picard 2D) to increase the hydro model stability and avoid having it crash under very dry conditions. See discussion 1187.

The default for fates_hydro_vg_alpha_node is changed from 0.005 to 0.12 MPa^-1. The previous small value led to unrealistic values of stem conductivity fraction over the Amazon Basin when using the van Genuchten hydraulic transfer function for plants (i.e. fates_hydro_htftype_node = 2 for all organs). See issue 1228. The new larger value was chosen to approximate the results from the default TFS hydraulic transfer function (fates_hydro_htftype_node = 1) with default hydro parameter values.
vg_alpha_test

Disclaimer: I have not tested this is a global run, just regionally over tropical South America.

Collaborators:

@rgknox

Expectation of Answer Changes:

The change to fates_hydro_vg_alpha_node will change model output significantly if you are using the van Genuchten hydraulic transfer function.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@jennykowalcz jennykowalcz added the parameter file Pertaining to changes to the FATES parameter file label Oct 14, 2024
@jennykowalcz jennykowalcz marked this pull request as ready for review October 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parameter file Pertaining to changes to the FATES parameter file
Projects
Development

Successfully merging this pull request may close these issues.

1 participant