Update values of fates_hydro_solver and fates_hydro_vg_alpha_node #1263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default values of the parameters
fates_hydro_solver
andfates_hydro_vg_alpha_node
.Description:
The default for hydro_solver is changed from 1 (Taylor 1D) to 2 (Picard 2D) to increase the hydro model stability and avoid having it crash under very dry conditions. See discussion 1187.
The default for fates_hydro_vg_alpha_node is changed from 0.005 to 0.12 MPa^-1. The previous small value led to unrealistic values of stem conductivity fraction over the Amazon Basin when using the van Genuchten hydraulic transfer function for plants (i.e. fates_hydro_htftype_node = 2 for all organs). See issue 1228. The new larger value was chosen to approximate the results from the default TFS hydraulic transfer function (fates_hydro_htftype_node = 1) with default hydro parameter values.
Disclaimer: I have not tested this is a global run, just regionally over tropical South America.
Collaborators:
@rgknox
Expectation of Answer Changes:
The change to fates_hydro_vg_alpha_node will change model output significantly if you are using the van Genuchten hydraulic transfer function.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: