Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix write of inventory init files #1244

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JessicaNeedham
Copy link
Contributor

@JessicaNeedham JessicaNeedham commented Sep 9, 2024

This PR fixes inventory initialization so that cohort and patch files can be written when do_inventory_out is true. After the refactor, either dbh or height needs to be negative in the cohort file, so this PR sets cohort height to -3.0 when writing the cohort file. It also changes formatting of file names (which seemed to work before but were broken by me in the last refactor I think). Not tested yet.

Collaborators:

Expectation of Answer Changes:

Should be bfb in all respects except that if do_inventory_out is true then files will be written out correctly rather than crashing the model.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

Not tested

@glemieux glemieux requested a review from rgknox October 21, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under Review
Development

Successfully merging this pull request may close these issues.

1 participant