implement subscription, acks & nacks in persistent subscriptions API #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
commented
Apr 21, 2021
| Persistent.read_req_options( | ||
| stream_identifier: Shared.stream_identifier(streamName: stream_name), | ||
| group_name: group_name, | ||
| buffer_size: opts[:buffer_size], |
There was a problem hiding this comment.
with EventStore 20+ you control the in-flight buffer in the connect... function
in the tcp client this was a setting on the psub itself. this seems like a nice improvement because you might have multiple consumers some which can batch-process more events at once than others based on available resources
Comment on lines
+124
to
+129
| messages = | ||
| if request.rpc.request_stream? and request.rpc.response_stream? do | ||
| message_buffer | ||
| else | ||
| [:eof | message_buffer] | ||
| end |
There was a problem hiding this comment.
this is the important part of the change to the connection: making sure to never send :eof (which ends the request stream) for a bi-directional stream rpc like persistent.Read
rpc Read (stream ReadReq) returns (stream ReadResp);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this finishes off the persistent subscriptions API
connects #7
in conjunction with #23
was about as complicated as I assumed it'd be: needed to add a bit to Spear.Connection to allow bi-direction streaming
pretty nice to be able to reuse
Spear.cancel_subscription/3for psubs as well. it works because the cancel mechanism is viaMint.HTTP2.cancel_request/2which just sends a GOAWAY frame that tells the server this request is done and don't send any more data on or receive any more data from this request stream