Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code changes to reflect data curation and cleanup results #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Code changes to reflect data curation and cleanup results #16

wants to merge 3 commits into from

Conversation

hlapp
Copy link
Member

@hlapp hlapp commented May 30, 2014

cd8b9d8

  • Changes directory of datafile.
  • Use correct column for date that is used as data publication date.
  • Accounts for NA entries in Google Scholar search query hits.

d2745fd

  • Changes selection of reference, because we now know exactly in which column to expect it.

hlapp
hlapp reviewed Jun 3, 2014
View reviewed changes
scripts/all_datasets.py

if __name__ == '__main__':
print 'repo\tid\twos\tgs\tyear'

for data_file in data_files:
path = os.path.join('data/repo_datasets', data_file)
# ls path = os.path.join('data/repo_datasets', data_file)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsheble would you mind deleting these # ls lines. Git tracks and highlights the exact change already, and so not keeping a commented-out version of the changed line actually makes the diff much clearer for seeing quickly what changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hlapp @lsheble