PM1.3 Team 3 #11

anrchen · 2018-02-26T04:57:08Z

Tasks
( The current version has been tagged as pm1 and submitted to EAS as .zip)

c) Refactor existing Java SOAP API per Perl’s structure

See splints/src/java/fp/v11/Splints/ for more details

d) Provide a simple JSON reader parser client (GET) for GitHub issues

[Updated] GitIssueDetails.java usage:

Go to lib/java folder
cd lib/java
Compile GitIssueDetails.java using javax.json-1.0.jar as class path
javac -classpath .:./javax.json-1.0.jar ../../src/java/fp/v11/github/GitHub.java
Go to src/java folder
cd ../../src/java/fp/v11
Run GitIssueDetails class using javax.json-1.0.jar as class path
java -classpath .:../../../../lib/java/javax.json-1.0.jar github/GitHub

e) Add a simple client to call RT create issues

RtCreateIssue.java usage:

1. Open project from ..\splints\src\java in Eclipse
2. Import JAR files as mentioned above
3. Change HOSTNAME and run RtCreateIssue.java

f) Bonus: enable CI build and install of a test RT system and auto-test your methods above.

Compilation test usage:

1. After cloning the project, cd into tools/ci
2. Run ./java-compile.sh

For more details

g) Bonus: Provide an equivalent Java API client for v12:

The current implementation of this feature involves establishing a Java Interface that uses the operations and services provided by FootPrints in their version 12. This interface can be found under
v12/FootPrints12Interface.java

For more details

sendGet(..) method should later be merged into an utility package containing all HTTP requests

RT client for create issues

Github Json Parser

…trieve from Foot Prints v12

Issue 7/refactoring

#7 [Update] Adding the initial operations and services that we can re…

#10 [Update] Bash script to compile all java files

smokhov · 2018-02-28T14:43:19Z

Thanks, I will review and comment as I go along until I mark as REVIEW DONE.

smokhov

Initial pass; more to follow when I get back to it.

smokhov · 2018-02-28T14:46:37Z

src/java/fp/v11/GitIssueDetails.java

+    * Usage: https://bitbucket.org/soen487-w18-03/soen487-w18-team03/issues/8/github-json-parser
+    */
+
+package fp.v11;


(A) This would naturally be github. instead of fp.v11.

smokhov · 2018-02-28T14:47:48Z

src/java/fp/v11/GitIssueDetails.java

+import javax.json.JsonString;
+
+
+public class GitIssueDetails {


(B) GitHub is a better class name

smokhov · 2018-02-28T16:18:55Z

src/java/fp/v11/RtCreateIssue.java

@@ -0,0 +1,90 @@
+package fp.v11;


(C) naturally, should be package rt;

smokhov · 2018-03-01T17:50:49Z

(D) fp/v11/Splints/ should remain lowercase

smokhov · 2018-03-01T17:54:27Z

(E) for your (f) docker_setup_tests.sh should call java-compile.sh for it to be truly integrated.

smokhov

Initial REVIEW DONE

smokhov · 2018-03-01T17:55:36Z

.gitignore

@@ -1,3 +1,5 @@
 # Ignore patterns

 *~
+
+.idea/


(F) why IntellIJ build system was removed?

smokhov · 2018-03-01T17:58:33Z

src/java/fp/v11/Splints/ISplints.java

+     * Gets issue details
+     * 
+     */
+    public void getIssueDetails();


(G) None of these should return void. It would be some kind of collection; for example a hashtable or a vector depending on the call. See what Perl is returning.

smokhov · 2018-03-01T17:58:49Z

src/java/fp/v11/Splints/ISplints.java

+     * Links two issues
+     * 
+     */
+    public void linkIssues();


(H) no void as well

smokhov · 2018-03-01T17:59:52Z

src/java/fp/v11/Splints/PromptCredentialsProvider.java

+
+    private final Console console;
+    private final Scanner scanner;
+    private final String USERNAME_INPUT_TEXT = "Your username: ";


(I) you provider is not a singleton, so constants like that should be static...

smokhov · 2018-03-01T18:02:28Z

src/java/fp/v12/FootPrints12Interface.java

+ *  Describes the services offered by
+ *  FootPrint version 12
+ */
+public interface FootPrints12Interface {


(J) as you probably realize this should be ISplints ... or an ISplints mapping to the API of FP12. Like what's an item? You can keep FootPrints12Interface for now then we need also ISplints here and an adapter implementing both.

smokhov · 2018-03-01T18:03:22Z

src/java/fp/v12/FootPrints12Interface.java

+    /**
+     *  CONTACT OPERATIONS
+     */
+    void createContract();


(K) this and similar others probably mean ..Contact.., not ..Contract..

smokhov · 2018-03-01T18:05:55Z

src/splints.iml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module type="JAVA_MODULE" version="4">


(L) I gather this belongs to a partial IntelliJ build system. It should not be in src/; recall your "src" is really under src/java/

smokhov · 2018-03-07T02:26:30Z

Merged to easier ublock PM2 contribs; need to re-check (A)-(L) TODOs, later.

smokhov · 2018-03-07T02:32:37Z

Contributes to #6.

smokhov · 2018-03-14T14:16:09Z

@qtdnguyen -- JFYI of what's coming

Splints rest service

ChristBian1 and others added 23 commits February 22, 2018 19:09

#7 Added credentials Provider

ea38db7

#7 Refactored logic from classes into methods

3fea5b8

Created class to call RT create issue

e4ba388

#9 Added required JAR files

ac0ec3c

#9 Added RT call for create issue

b6efd75

Provide a simple JSON reaer parser client for GitHub issues

78b4aa4

Added javax.jar library for JSON parser

b97a5ed

Updated sendGet(..) method comment

7f654bd

sendGet(..) method should later be merged into an utility package containing all HTTP requests

#9 Moved jar files to new path under lib/java

95246e9

#9 Deleted JAR folder

e725497

#7 Fixed some formatting issues

263fd98

#7 Minor refactoring

60120cd

#9 Modified class to incorporate methods

63b806d

Merge pull request #1 from anrchen/RT-Client

f7f577c

RT client for create issues

Merge pull request #2 from anrchen/github-issue-details

211b05d

Github Json Parser

Removed old CreateIssue class

7caea9f

#7 [Update] Adding the initial operations and services that we can re…

6c4b190

…trieve from Foot Prints v12

[Update] configuring to use intellij as an ide

f6f8dd3

Merge pull request #3 from anrchen/issue-7/refactoring

48ebac8

Issue 7/refactoring

Merge branch 'master' into issue-11

3adb6f9

Merge pull request #4 from anrchen/issue-11

528371b

#7 [Update] Adding the initial operations and services that we can re…

#10 [Update] Bash script to compile all java files

aec8593

Merge pull request #5 from anrchen/issue-10

98b3903

#10 [Update] Bash script to compile all java files

smokhov reviewed Feb 28, 2018

View reviewed changes

smokhov reviewed Mar 1, 2018

View reviewed changes

smokhov self-assigned this Mar 1, 2018

anrchen mentioned this pull request Mar 5, 2018

GitHub & RT task class and package refactor anrchen/splints#7

Merged

smokhov changed the base branch from master to team3 March 7, 2018 02:23

smokhov added enhancement Java labels Mar 7, 2018

smokhov merged commit 30825e2 into NAG-DevOps:team3 Mar 7, 2018

smokhov mentioned this pull request Mar 7, 2018

java: CI: add compilation tests #6

Open

anrchen mentioned this pull request Mar 13, 2018

PM1 Refactor Team 3 #12

Merged

12 tasks

smokhov mentioned this pull request Mar 18, 2018

java: need to update README with the API coverage #15

Open

smokhov pushed a commit that referenced this pull request Mar 30, 2018

Merge pull request #11 from anrchen/Splints-Rest-Service

a4e3af8

Splints rest service

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PM1.3 Team 3 #11

PM1.3 Team 3 #11

anrchen commented Feb 26, 2018 •

edited

Loading

smokhov commented Feb 28, 2018

smokhov left a comment

smokhov Feb 28, 2018

smokhov Feb 28, 2018

smokhov Feb 28, 2018

smokhov commented Mar 1, 2018

smokhov commented Mar 1, 2018

smokhov left a comment

smokhov Mar 1, 2018

smokhov Mar 1, 2018

smokhov Mar 1, 2018

smokhov Mar 1, 2018

smokhov Mar 1, 2018

smokhov Mar 1, 2018

smokhov Mar 1, 2018

smokhov commented Mar 7, 2018

smokhov commented Mar 7, 2018

smokhov commented Mar 14, 2018

		@@ -0,0 +1,12 @@
		<?xml version="1.0" encoding="UTF-8"?>
		<module type="JAVA_MODULE" version="4">

PM1.3 Team 3 #11

PM1.3 Team 3 #11

Conversation

anrchen commented Feb 26, 2018 • edited Loading

c) Refactor existing Java SOAP API per Perl’s structure

d) Provide a simple JSON reader parser client (GET) for GitHub issues

e) Add a simple client to call RT create issues

f) Bonus: enable CI build and install of a test RT system and auto-test your methods above.

g) Bonus: Provide an equivalent Java API client for v12:

smokhov commented Feb 28, 2018

smokhov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smokhov commented Mar 1, 2018

smokhov commented Mar 1, 2018

smokhov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smokhov commented Mar 7, 2018

smokhov commented Mar 7, 2018

smokhov commented Mar 14, 2018

anrchen commented Feb 26, 2018 •

edited

Loading