No need to refresh model if the model sets the data to the index #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am afraid (and almost sure) that this is a workaround for a problem which should not exist in the first place. |
exactly-one-kas
approved these changes
Jun 6, 2022
| @@ -160,6 +160,7 @@ class DiffTreeModel : public QAbstractItemModel { | |||
| git::Repository mRepo; | |||
|
|
|||
| bool mListView = false; | |||
| bool suppressRefresh{false}; | |||
There was a problem hiding this comment.
Maybe add a comment to indicate that this is just a workaround?
There was a problem hiding this comment.
Good idea, I will do. We can let this mr at the moment aside, because it is not that important
Murmele
force-pushed
the
StageNoRefresh
branch
from
a838651
to
0e0b78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a cleaner solution, we can change it.