Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getter setters #133

Merged
merged 8 commits into from
Oct 19, 2024
Merged

Getter setters #133

merged 8 commits into from
Oct 19, 2024

Conversation

shivasankarka
Copy link
Collaborator

  • Fixed and rewrote the adjust_slice function that was causing errors.
  • Temporarily removed negative indexing support in slices since it causes error. Will add just feature in later updates.
  • Added test for slicing in getters. Complete tests for setters will be added later (due to python interop limitation)

@MadAlex1997 MadAlex1997 merged commit bfa5825 into Mojo-Numerics-and-Algorithms-group:pre-0.4 Oct 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadAlex1997 MadAlex1997 MadAlex1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivasankarka @MadAlex1997