[fix] Fix the issues with solve, inv, and matmul
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forFudan
changed the title
solve and invsolve, inv, and matmul
MadAlex1997
approved these changes
Sep 27, 2024
MadAlex1997
merged commit ea6ef61
into
Mojo-Numerics-and-Algorithms-group:experimental
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to solve the issue with
solveandinvdue to problems in paralellization.For
solve: Disable the parallelism and use normal loop approach for the moment until the issue is resolved.For
inv: The approach to calculate inverse is to solve the systemAB=I, whereIis an identity matrix, with the functionsolve. This is also what Numpy does.For
matmul: It seems to be related to ASAP destruction policy and can be resolved by using the variables after the paralellization.