-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes eco_labels plural in vehicle_types #559
Conversation
The field `eco_labels` in vehicle_types is an Array of objects so the field name should be plural.
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Monday, November 13th. |
Tagging recent contributors for visibility: @simonsolnes, @PierrickP, @futuretap, @testower, @cmonagle, @ezmckinn, @Cj-Malone, @tdelmas, @AntoineAugusti, @ArashMansouri. Thank you! |
Entur votes in favor of this proposal |
At Vulog we're ok with this |
Fluctuo: We vote for ! ✅ |
+1 from Transit |
Voting on this PR closes in 3 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
This vote has now closed, and it passes! Votes in favor: This change will be added to v3.0-RC2, which will be released in the coming days. |
What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.
As discussed in #542, the field
eco_labels
in vehicle_types.json is an Array of objects so the field name should be plural.What is the proposal?
Change the field name from
eco_label
-->eco_labels
(plural) in vehicle_types.json.Is this a breaking change?
Which files are affected by this change?
vehicle_types.json