Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes eco_labels plural in vehicle_types #559

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Oct 27, 2023

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

As discussed in #542, the field eco_labels in vehicle_types.json is an Array of objects so the field name should be plural.

What is the proposal?

Change the field name from eco_label --> eco_labels (plural) in vehicle_types.json.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

vehicle_types.json

The field `eco_labels` in vehicle_types is an Array of objects so the field name should be plural.
@richfab richfab added gbfs.md v3.0-RC2 Candidate change for GBFS 3.0 (Major release) - 2nd pass labels Oct 27, 2023
gbfs.md Outdated Show resolved Hide resolved
@richfab
Copy link
Contributor Author

richfab commented Nov 3, 2023

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Monday, November 13th.
Please vote for or against the proposal, and include the organization for which you are voting in your comment.
Please note if you can commit to implementing the proposal.

@richfab
Copy link
Contributor Author

richfab commented Nov 6, 2023

Tagging recent contributors for visibility: @simonsolnes, @PierrickP, @futuretap, @testower, @cmonagle, @ezmckinn, @Cj-Malone, @tdelmas, @AntoineAugusti, @ArashMansouri. Thank you!

@testower
Copy link
Contributor

testower commented Nov 6, 2023

Entur votes in favor of this proposal

@jkurzanski
Copy link

At Vulog we're ok with this

@PierrickP
Copy link

Fluctuo: We vote for ! ✅

@cmonagle
Copy link
Contributor

cmonagle commented Nov 9, 2023

+1 from Transit

@richfab
Copy link
Contributor Author

richfab commented Nov 10, 2023

Voting on this PR closes in 3 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

@richfab
Copy link
Contributor Author

richfab commented Nov 14, 2023

This vote has now closed, and it passes!

Votes in favor:
Entur (consumer)
Vulog (producer)
Fluctuo (consumer)
Transit app (consumer)

There were no votes against.

This change will be added to v3.0-RC2, which will be released in the coming days.

@richfab richfab merged commit ac7c617 into master Nov 14, 2023
2 checks passed
@richfab richfab deleted the fix/eco_label-plural branch November 14, 2023 16:59
@richfab richfab removed the request for review from davidgamez November 14, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md v3.0-RC2 Candidate change for GBFS 3.0 (Major release) - 2nd pass Vote Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants