Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing auto-discovery URL for linka_aar_bike #550

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

drewda
Copy link
Contributor

@drewda drewda commented Oct 5, 2023

Please review and consider adding this fix to one of the recently added GBFS auto-discovery URLs.

We noticed this when it broke our down-stream script that ingests a portion of the fields from systems.csv: transitland/transitland-atlas@2c11b47#diff-839c6874cb906b6656180f2fd649476ba38ca60b0db9e67cc05c72eec224f18eR8

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @drewda!
I left a suggestion. LGTM otherwise!

systems.csv Outdated Show resolved Hide resolved
Co-authored-by: Fabien Richard-Allouard <fabien@mobilitydata.org>
@drewda
Copy link
Contributor Author

drewda commented Oct 5, 2023

@richfab thanks for reviewing!

Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
Merging now 🚀

@richfab richfab merged commit d582a8d into MobilityData:master Oct 5, 2023
1 check passed
@drewda drewda deleted the patch-1 branch October 23, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants