Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.5.x Decadeus Update #165

Merged
merged 10 commits into from
Jul 19, 2023
Merged

2.4.5.x Decadeus Update #165

merged 10 commits into from
Jul 19, 2023

Conversation

MitchTalmadge
Copy link
Owner

@MitchTalmadge MitchTalmadge commented Jul 17, 2023

  • Updated Dockerfile and entrypoint scripts for new release process introduced with AMP 2.4.5.0
  • Completely re-organized entrypoint into more maintainable functions
  • Added improved error handling, especially when creating the main instance. Fixes Detect invalid licence key on startup #55
  • Removed old Java 16 -> 17 upgrade notice.
  • Removed outdated "Check for Updates" GitHub Action.
    • I may go back on this -- still thinking about it.
    • With this, we will no longer be caching the latest AMP version inside the image itself. My goal was to make better use of the built-in update mechanisms in AMP to improve this container's longevity. The AMP upgrades will be downloaded on startup, unless the AMP_AUTO_UPDATE env var is set to false.
    • To clarify: If you want to update AMP, just reboot the container. It happens automatically. No need to pull the image.
    • If ampinstmgr has an update, I will release a new image version after testing to make sure that it still works with our entrypoint. Based on ampinstmgr's past, this will be infrequent.
  • LICENCE is now AMP_LICENCE, MODULE is now AMP_MODULE, NIGHTLY=true is now AMP_RELEASE_STREAM=Development.
    • Each of these are backwards compatible, old docker configs do not need to change.

@MitchTalmadge MitchTalmadge added the enhancement New feature or request label Jul 17, 2023
@MitchTalmadge MitchTalmadge self-assigned this Jul 17, 2023
This was referenced Jul 17, 2023
@MitchTalmadge
Copy link
Owner Author

I upgraded a copy of my old 2.4.4.0 AMP server to 2.4.5 with this image, and it worked great. Have had no issues so far.

@IceOfWraith
Copy link
Contributor

To get this to Ubuntu 22.04 all you need to do is the following three changes:

Line 1 - FROM ubuntu:22.04
Line 107 - lib32gcc-s1 \
Line 161 - RUN wget -qO - http://repo.cubecoders.com/archive.key | gpg --dearmor > /etc/apt/trusted.gpg.d/cubecoders-archive-keyring.gpg && \

@MitchTalmadge
Copy link
Owner Author

Thank you @IceOfWraith! Here's a PR with those changes: #166

@IceOfWraith
Copy link
Contributor

Very good! Didn't want to step on the changes you were working on here. :)

I'll let you know when I have the Wine/Xvfb changes ready and do a PR as well.

@MitchTalmadge
Copy link
Owner Author

I saw your PR #168! It looks awesome. I'm gonna merge this PR into staging since I haven't had any issues with it. Then we can test your additions and merge that in as well.

@MitchTalmadge MitchTalmadge merged commit a9f16e9 into staging Jul 19, 2023
5 checks passed
@MitchTalmadge MitchTalmadge deleted the staging-decadeus branch July 19, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants