Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #126's
ModBindings
refactor & toggle key handling, this PR:FreecamComboKeyMapping
Freecam
toactivateTripodHandler()
&resetTripodHandler()
,I also removed
ModBinding
's "wrapper" methods;They only existed to make using the enum values prettier, that is now unnecessary because the keybinds to define their own logic & don't care about the enum.
The one exception to this is in
MinecraftMixin
, however a couple.get()
s is worth the reduced complexity/maintenance IMO.If you disagree, then 00a5b73 can be dropped or reverted easily.
This PR does not affect the existing behavior in any way.