Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable zkapp commands implementation #14885

Merged
merged 15 commits into from
Jan 25, 2024

Conversation

ejMina226
Copy link
Member

Implementation of #14880

@ejMina226 ejMina226 self-assigned this Jan 16, 2024
@ejMina226 ejMina226 marked this pull request as ready for review January 16, 2024 21:56
@ejMina226 ejMina226 requested a review from a team as a code owner January 16, 2024 21:56
@ejMina226
Copy link
Member Author

!ci-build-me

1 similar comment
@ejMina226
Copy link
Member Author

!ci-build-me

src/lib/mina_base/user_command.ml Outdated Show resolved Hide resolved
@ejMina226
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member

!approved-for-mainnet

src/lib/mina_base/user_command.ml Outdated Show resolved Hide resolved
src/lib/mina_base/user_command.ml Outdated Show resolved Hide resolved
@ejMina226
Copy link
Member Author

!ci-build-me

@ejMina226
Copy link
Member Author

@georgeee Thanks for the review. Could you approve when you're happy?

src/lib/mina_base/user_command.ml Outdated Show resolved Hide resolved
src/lib/mina_base/user_command.ml Outdated Show resolved Hide resolved
@ejMina226
Copy link
Member Author

!ci-build-me

@georgeee georgeee force-pushed the disable-zkapp-changes-implementation branch from e9525df to a360709 Compare January 24, 2024 12:21
@georgeee
Copy link
Member

!ci-build-me

@ejMina226
Copy link
Member Author

!ci-build-me

@georgeee georgeee changed the base branch from rampup to berkeley January 24, 2024 18:29
@georgeee
Copy link
Member

@ejMina226 may I ask you to merge berkeley into this branch?

@ejMina226
Copy link
Member Author

!ci-build-me

@ejMina226
Copy link
Member Author

@georgeee I've merged berkeley in. Looks like there are some issues with the pipeline.

@ejMina226
Copy link
Member Author

!ci-build-me

@deepthiskumar
Copy link
Member

!ci-nightly-me

@mrmr1993
Copy link
Member

!approved-for-mainnet

@deepthiskumar
Copy link
Member

@stevenplatt
Copy link
Contributor

A fix for the failing rosetta container builds should be in place now. I have restarted the nightly CI pipeline to confirm:
https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/1201

@mrmr1993
Copy link
Member

!ci-build-me

@mrmr1993
Copy link
Member

!approved-for-mainnet

@ejMina226 ejMina226 merged commit 5403e40 into berkeley Jan 25, 2024
39 checks passed
@ejMina226 ejMina226 deleted the disable-zkapp-changes-implementation branch January 25, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants