-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] add nix check to CI #13884
[CI] add nix check to CI #13884
Conversation
!ci-build-me |
2 similar comments
!ci-build-me |
!ci-build-me |
cddccee
to
9210c04
Compare
5de9413
to
ede1326
Compare
!ci-build-me |
!ci-build-me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are changes to batch_txn_tool
related to Nix?
Apart from the above it looks good to me. Changes accidentally breking Nix in the past were so annoying. It's great that we're taking steps to avoid it in the future!
Apologies for not stating that in description. Compilation failures in batch_txn_tool causes |
That's what I thought, but wanted to make sure. Thanks! |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!approved-for-mainnet |
Explain your changes:
Based on recent failure in nix caused by libp2p update we need nix build verification on Pull request. After quick analysis it looks like it is simplest not to use buildkite but github action.
Explain how you tested your changes:
Observed job in CI
Checklist: