Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] add nix check to CI #13884

Merged
merged 18 commits into from
Sep 20, 2023
Merged

[CI] add nix check to CI #13884

merged 18 commits into from
Sep 20, 2023

Conversation

dkijania
Copy link
Member

@dkijania dkijania commented Aug 17, 2023

Explain your changes:
Based on recent failure in nix caused by libp2p update we need nix build verification on Pull request. After quick analysis it looks like it is simplest not to use buildkite but github action.

Explain how you tested your changes:
Observed job in CI

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dkijania dkijania self-assigned this Aug 17, 2023
@dkijania dkijania changed the base branch from develop to berkeley August 17, 2023 13:03
@dkijania
Copy link
Member Author

!ci-build-me

2 similar comments
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania changed the title Dkijania/add nix to ci [CI] add nix check to CI Aug 17, 2023
@dkijania dkijania marked this pull request as ready for review August 29, 2023 21:33
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

Copy link
Contributor

@Sventimir Sventimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are changes to batch_txn_tool related to Nix?

Apart from the above it looks good to me. Changes accidentally breking Nix in the past were so annoying. It's great that we're taking steps to avoid it in the future!

.github/workflows/nix.yml Show resolved Hide resolved
@dkijania
Copy link
Member Author

Apologies for not stating that in description. Compilation failures in batch_txn_tool causes nix build mina to fail. I think we didn't noticed that as we using more nix develop mina and then dune build .... rather than previous command

@Sventimir
Copy link
Contributor

Apologies for not stating that in description. Compilation failures in batch_txn_tool causes nix build mina to fail. I think we didn't noticed that as we using more nix develop mina and then dune build .... rather than previous command

That's what I thought, but wanted to make sure. Thanks!

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit c7d65e0 into berkeley Sep 20, 2023
11 checks passed
@deepthiskumar deepthiskumar deleted the dkijania/add_nix_to_ci branch September 20, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants