Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TabBar issues with multiple tabs #3546

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented Jul 25, 2024

We kept having issues with TabBar when project had multiple tabs, for example:
Screenshot 2024-07-25 at 13 37 46

Solution: use ListView instead of TabBar 🙃

ListView is set to mimic the behaviour of TabBar (horizontal orientation), the same project now looks like this:
Screenshot 2024-07-25 at 14 59 08

There is a behavioural change for sections - I limited it to use only ViewSection.InlineLabels, because CurrentLabelAtStart was also producing some issues (see https://doc.qt.io/qt-6/qml-qtquick-listview.html#section-prop)

Copy link

Pull Request Test Coverage Report for Build 10096419190

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 62 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 60.039%

Files with Coverage Reduction New Missed Lines %
input/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
input/core/merginuserinfo.cpp 1 75.18%
input/app/mmstyle.h 60 1.97%
Totals Coverage Status
Change from base Build 10040562947: 0.04%
Covered Lines: 7703
Relevant Lines: 12830

💛 - Coveralls

@VitorVieiraZ VitorVieiraZ self-requested a review July 26, 2024 02:07
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it in some projects that use tabs, and everything seems good here.

@tomasMizera tomasMizera changed the title Replace TabBar with ListView Fix TabBar issues with multiple tabs Jul 26, 2024
@tomasMizera tomasMizera marked this pull request as ready for review July 26, 2024 12:36
@tomasMizera tomasMizera added this to the 2024.3.1 milestone Jul 26, 2024
Copy link
Contributor

@PeterPetrik PeterPetrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - sad to see another Qt bug in core components like TabBar

@tomasMizera
Copy link
Collaborator Author

@jozef-budac note for testing: we will need to test tabs behaviour - dynamic hiding and so on

@tomasMizera tomasMizera merged commit a61364b into master Jul 26, 2024
12 checks passed
@tomasMizera tomasMizera deleted the fix-tab-bar-issues branch July 26, 2024 14:24
@jozef-budac
Copy link

We have this in the regression run. So I believe it should be covered. One issue is probably related to it: #3552. It looks like an iOS problem. I can see it on android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants