Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Payment step transaction verification of the data #60

Merged
merged 31 commits into from
Jan 6, 2024
Merged

Payment step transaction verification of the data #60

merged 31 commits into from
Jan 6, 2024

Conversation

PaulIRVOAS
Copy link
Collaborator

No description provided.

@PaulIRVOAS
feat(dependencies): add common to dependencies
487cf6d
@PaulIRVOAS
fix(account): change scale to balance decimal
2562914
@PaulIRVOAS
feat(repository): add function to get PaymentMethod
a6f1639
@PaulIRVOAS
feat(transaction): check if PaymentMethod is ok
4b1b897
@PaulIRVOAS
feat(transaction): add logic on transaction step
4e08121
@PaulIRVOAS
fix(database): rename package name to entity
d8111af
@PaulIRVOAS
fix(database): rename package name to repository
dc5b9ed
@PaulIRVOAS
fix(database): rename package name to enumeration
23f5b2c
@PaulIRVOAS
fix(database): change file location to common module
b71a068
@PaulIRVOAS
fix(database): remove useless file
9d4884b
@PaulIRVOAS
feat(dependencies): add common dependencies to database module
686cedf
@PaulIRVOAS
fix(file): remove useless lines and change type
404a29e
@PaulIRVOAS
fix(verification): auto change to import packages
82fe619
@PaulIRVOAS
feat(account): add account and his implementation
c8bdb4f
@PaulIRVOAS
feat(transaction): add received object from mediator for transaction …
9bbe5f3 
…steps
@PaulIRVOAS
fix(transaction): rename file name
93eca6a
@PaulIRVOAS
fix(controller): rename useless controllers
db5e798
@PaulIRVOAS
feat(dependencies): add dependencies
066ee04
@PaulIRVOAS
fix(repository): add constraint to remove error
f92eef1
@PaulIRVOAS
fix(repository): add constraint to remove error
d2d32e5
@PaulIRVOAS
feat(logs): add logs
eddfeb9
@PaulIRVOAS
feat(mapper): add mapper dependency and interface for Transaction
4a32d8a
@PaulIRVOAS PaulIRVOAS self-assigned this Jan 4, 2024
@PaulIRVOAS PaulIRVOAS linked an issue Jan 4, 2024 that may be closed by this pull request
Payment step - Transaction : verification of the data from the payment method (back - module payment) #10
Closed
3 tasks
@PaulIRVOAS
Copy link
Collaborator Author

PaulIRVOAS commented Jan 4, 2024 •
edited
Loading

Requested by @MeloLawson ->

  • TransactionController -> please save a Transaction object in DB + set transaction status before pushing in DB.
  • PaymentMethodService -> take a look on the wanted account object, it is recovered ?

MeloLawson
MeloLawson suggested changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@MeloLawson MeloLawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion about in the controller/paymentMethodService

...ction/src/main/java/com/cashmanager/server/transaction/controller/TransactionController.java Outdated Show resolved Hide resolved
@PaulIRVOAS PaulIRVOAS merged commit d8311cd into main Jan 6, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MeloLawson MeloLawson MeloLawson approved these changes

Assignees

@PaulIRVOAS PaulIRVOAS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Payment step - Transaction : verification of the data from the payment method (back - module payment)
2 participants
@PaulIRVOAS @MeloLawson