Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Conversation

MeloLawson
Copy link
Collaborator

@MeloLawson MeloLawson commented Dec 22, 2023

Add the module product, the ProductController and ProductService. Add a seeder class for the products table.
Add Mapper and Swagger doc.

linked #15

Add the module product, the ProductController and ProductService. Add Mapper and Swagger doc

linked #15
change the shop module structure and add a new module shop_database that contains all the entities and repositories of shop
add a line in the README about swagger

linked #15
add configuration files to write in the correct databse (shop_db)
add unit tests

linked #15
@MeloLawson MeloLawson force-pushed the feature/15-product-management-view-of-the-products-recuperate-the-list-of-products branch from b493ce1 to 220bf58 Compare January 3, 2024 18:58
@MeloLawson MeloLawson marked this pull request as ready for review January 3, 2024 19:03

@Profile("dev")
@Configuration
public class FlywayConfiguration {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation for others,
Doc for Flyway and how to use it : https://www.baeldung.com/database-migrations-with-flyway

Copy link
Collaborator

@PaulIRVOAS PaulIRVOAS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lack of documentaion on top level class, e.g : ProductController, ProductService, etc..
Otherwise, nice job, PR approved.

@MeloLawson MeloLawson merged commit 007e69a into main Jan 6, 2024
1 check passed
@MeloLawson MeloLawson deleted the feature/15-product-management-view-of-the-products-recuperate-the-list-of-products branch January 6, 2024 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants