This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/16 product management view the list of products #58
Merged
MansourWolou
merged 7 commits into
main
from
feat/16-product-management-view-the-list-of-products_FIXED_BIS
Dec 24, 2023
Merged
Feat/16 product management view the list of products #58
MansourWolou
merged 7 commits into
main
from
feat/16-product-management-view-the-list-of-products_FIXED_BIS
Dec 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft linked #16
add the layout of home page and products list page linked #16
implementation of the bloc architecture for the state management of the product view linked #16
add the terminal part in the readme and correction in the code for the build linked #16
corrections in the test files and apis.dart linked #16
change name widget_test.dart.old and typo correction in products_bloc_test.dart linked #16
update the DataState class in usecase with the new changes, correct typo in product_bloc_test.dart linked #16
MelvinCou
reviewed
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed the command dart format .
to format code.
Please run this command and maybe add to CI (with argument --set-exit-if-changed
).
@@ -1,11 +1,35 @@ | |||
import 'package:equatable/equatable.dart'; | |||
|
|||
class Product extends Equatable { | |||
final int id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Products have a UUID identifier, please use uuid instead.
This change has several side effects on the code, be careful!
MansourWolou
approved these changes
Dec 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All 'TODO' comment will be apply in futur issue.
MansourWolou
deleted the
feat/16-product-management-view-the-list-of-products_FIXED_BIS
branch
December 24, 2023 07:31
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the feature for the view of the list of the products in the mobile app
After updating, run "flutter pub get" in the terminal to download the dependencies.