refactor(terminal: naming error

Correct json key name Linked #42
MelvinCou · Dec 19, 2023 · c50612e · c50612e
1 parent 92b90c6
commit c50612e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 24 deletions.
diff --git a/terminal/lib/features/product/domain/usecase/get_product.dart b/terminal/lib/features/product/domain/usecase/get_product.dart
@@ -15,6 +15,7 @@ class GetProduct implements UseCase<List<Product>, void> {
         //return product list
         return result.data;
       } else {
+        //Todo: Implement error handling
         throw Exception("Didn't get products ; result.errorMessage");
       }
     } catch (err) {

diff --git a/terminal/lib/features/transaction/domain/usecase/get_check_data.dart b/terminal/lib/features/transaction/domain/usecase/get_check_data.dart
@@ -6,6 +6,7 @@ import 'package:terminal/features/transaction/domain/entity/check.dart';
 import 'package:flutter_zxing/flutter_zxing.dart';
 
 class GetCheckData implements UseCase<DataState, Code> {
+  // test Qr code scnaning with https://fr.qr-code-generator.com/
   @override
   Future<DataState> call({Code? params}) {
     late DataState result;
@@ -18,38 +19,19 @@ class GetCheckData implements UseCase<DataState, Code> {
         throw Exception("The scan result is not a string or empty");
       }
 
-      //* valild json : {"checkNumer":468516,"amount":85}
+      //* valild json : {"checkNumber":468516,"amount":85}
       data = jsonDecode(params.text!);
 
       if (data["amount"] is! int || data["checkNumber"] is! int) {
         throw Exception("json data not valid");
       }
 
       result = Success(
-          Check(amount: data["amount"], checkNumber: data["checkNumer"]));
+          Check(amount: data["amount"], checkNumber: data["checkNumber"]));
     } catch (e) {
       result = Error(e);
     }
 
     return Future(() => result);
   }
 }
-    // if (params!.text != null) {
-    //   if (params.text!.isNotEmpty && params.text is String) {
-    //     //* valild json : {"checkNumer":468516,"amount":85}
-
-    //     data = jsonDecode(params.text!);
-
-    //     if (data["amount"].runtimeType is int ||
-    //         data["checkNumer"].runtimeType is int) {
-    //       result = Success(
-    //           Check(amount: data["amount"], checkNumber: data["checkNumer"]));
-    //     } else {
-    //       result = Error("json data not valid");
-    //     }
-    //   } else {
-    //     result = Error("The scan result is not a string or empty");
-    //   }
-    // } else {
-    //   result = Error("params is null");
-    // }
diff --git a/terminal/test/domain/usecase/get_check_data_test.dart b/terminal/test/domain/usecase/get_check_data_test.dart
@@ -8,7 +8,7 @@ void main() {
   test('GetCheckData call method with valid JSON data', () async {
     // Arrange
     final useCase = GetCheckData();
-    final code = Code(text: '{"checkNumer":468516,"amount":85}');
+    final code = Code(text: '{"checkNumber":468516,"amount":85}');
 
     // Act
     final result = await useCase.call(params: code);
@@ -22,7 +22,7 @@ void main() {
   test('should throw exception for invalid JSON data', () async {
     // Arrange
     final useCase = GetCheckData();
-    final code = Code(text: '{"checkNumer":468516,"amount":"85"}');
+    final code = Code(text: '{"checkNumber":468516,"amount":"85"}');
 
     // Act
     final result = await useCase.call(params: code);
@@ -60,7 +60,7 @@ void main() {
   });
   test("Should return Error for unvalid check data ", () async {
     final useCase = GetCheckData();
-    final code = Code(text: '{"Checknumer":468516,"amount":HACKER}');
+    final code = Code(text: '{"checkNumber":468516,"amount":HACKER}');
 
     final result = await useCase(params: code);