Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalanced Random Unit Quality #5126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Oct 23, 2024

This PR rebalances the random unit quality table to no longer be based on the old AtB tables.

A was 27.78% now 8.33% (-19.45%)
B was 44.44% now 19.44% (-25.00%)
C was 19.44% now 30.56% (+11.12%)
D was 5.56% now 25.00% (+19.44%)
E was 0% now 13.89% (+13.89%)
F was 2.78% now 2.78% (no change)

Units are now 44.45% more likely to be C quality (no maintenance modifier) or better.

@IllianiCBT IllianiCBT added the UX User experience label Oct 23, 2024
@IllianiCBT IllianiCBT self-assigned this Oct 23, 2024
@WeaverThree
Copy link
Contributor

Oh nice! That looks like a good distribution!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.53%. Comparing base (3352c18) to head (0702c03).
Report is 23 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5126      +/-   ##
============================================
- Coverage     10.54%   10.53%   -0.01%     
- Complexity     6040     6041       +1     
============================================
  Files           956      956              
  Lines        134181   134213      +32     
  Branches      19481    19489       +8     
============================================
- Hits          14144    14140       -4     
- Misses       118693   118722      +29     
- Partials       1344     1351       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants