Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label OmniUnits as Omni in the MekHQ UI #5121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WeaverThree
Copy link
Contributor

Omni units have different rules in regards to refits and such that matter in MekHQ more than in MegaMek, so I thought it would be nice to distinguish them a little more clearly.

Omni units sort after non-omni units of the same type.

Unit list filters don't change, e.g. OmniMeks and Meks are both listed under the Mek filter.

2024-10-23_094534
2024-10-23_094608
2024-10-23_094649

Also kills a couple deprecaiton warnings along the way.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.52%. Comparing base (3352c18) to head (5b29f78).
Report is 23 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5121      +/-   ##
============================================
- Coverage     10.54%   10.52%   -0.02%     
+ Complexity     6040     6032       -8     
============================================
  Files           956      956              
  Lines        134181   134241      +60     
  Branches      19481    19497      +16     
============================================
- Hits          14144    14129      -15     
- Misses       118693   118760      +67     
- Partials       1344     1352       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants