Globally fix slow mousewheeling issues, with scaling! #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -285,7 +286,7 @@ | |||
|
|
|||
| /* ATB */ | |||
| panLanceAssignment = new LanceAssignmentView(getCampaign()); | |||
| JScrollPane paneLanceDeployment = new JScrollPane(panLanceAssignment); | |||
| JScrollPane paneLanceDeployment = new JScrollPaneWithSpeed(panLanceAssignment); | |||
Check notice
Code scanning / CodeQL
Unread local variable Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5103 +/- ##
============================================
+ Coverage 10.42% 10.54% +0.11%
- Complexity 6035 6038 +3
============================================
Files 953 956 +3
Lines 134268 134164 -104
Branches 19456 19472 +16
============================================
+ Hits 14003 14142 +139
+ Misses 118922 118673 -249
- Partials 1343 1349 +6 ☔ View full report in Codecov by Sentry. |
IllianiCBT
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JScrollPane. They're everywhere. Sometimes the mousewheel scrolling works fine with them, sometimes it doesn't. There doesn't seem to be any pattern to when it works.MegaMek and MegaMekLab already control their
JScrollPanes withget*ScrollBar().setUnitIncrement(int), seemingly doing it for each one separately. HQ only does it for the StratCon map.Something like two-thirds of HQ's are anonymous, which makes setting properties on them a bother.
This implements a drop-in replacement for
JScrollPane,JScrollPaneWithSpeed, which sets its own increment modified by the GUI scale factor, and replaces all uses ofJScrollPanewith it. (Except that Stratcon Map one.) This provides a single point for tuning and would allow for customization down the line.