Fixed Divide by Zero Error in Loans Dialog #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the logic to enforce a minimum interest rate of 1% when setting the interest rate for new loans.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5072 +/- ##
============================================
+ Coverage 10.42% 10.54% +0.11%
- Complexity 6035 6044 +9
============================================
Files 953 955 +2
Lines 134268 134145 -123
Branches 19456 19473 +17
============================================
+ Hits 14003 14150 +147
+ Misses 118922 118650 -272
- Partials 1343 1345 +2 ☔ View full report in Codecov by Sentry. |
|
Should 1% be the basement? History today has some example of sub-prime loans to large organizations, and even near 0% to individuals. I've seen one at .149% as recent as last year. |
|
Pick a number and I'll implement it. It's a very easy thing to change :) |
IllianiCBT
changed the title
Updated `Loan.java` to correctly calculate payment amount when interest is zero. Removed unnecessary minimum rate enforcement in `NewLoanDialog.java` to allow for zero interest rates.
|
Updated description based on Hammer's feedback. |
HammerGS
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event there is 0% interest on a loan we now divide the loan principal by the number of payments.
Closes #5023