Corrected Scenario Modifiers for HouseOfficer units
#5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed HouseOfficerAir and HouseOfficerGround XML files to ensure both now contribute to Battle Value (BV) and unit count. This adjustment improves scenario balancing and ensures accurate unit evaluation in deployments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5036 +/- ##
============================================
- Coverage 10.44% 10.43% -0.02%
- Complexity 6015 6022 +7
============================================
Files 950 952 +2
Lines 133511 133810 +299
Branches 19400 19432 +32
============================================
+ Hits 13948 13961 +13
- Misses 118217 118498 +281
- Partials 1346 1351 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
HouseOfficerAirandHouseOfficerGroundXML files to ensure both now correctly contribute to BV and unit count.