Add option to show unit images in TO&E #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5024 +/- ##
============================================
- Coverage 10.46% 10.46% -0.01%
- Complexity 6022 6026 +4
============================================
Files 950 950
Lines 133437 133481 +44
Branches 19383 19393 +10
============================================
+ Hits 13967 13969 +2
- Misses 118124 118163 +39
- Partials 1346 1349 +3 ☔ View full report in Codecov by Sentry. |
|
This has picked up conflicts. |
HammerGS
approved these changes
Oct 11, 2024
|
Conflicts resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another Weaver-annoying low-hanging fruit, this one adds an option to show the images of the actual units in the TO&E rather than people's portraits. The portraits do nothing to help me identify which units I'm looking at. Plus half the time I'm playing with portrait generation disabled so everyone is a silhouette.