Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Advanced Medical Injuries in UI #5017

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

WeaverThree
Copy link
Contributor

The numerical hit counter in the force display in the TO&E and the injuries column in the Personnel tab were both only showing "hits" from when advanced medical is turned off. This fixes them so they work with both systems. Are there any other places I need to hit with this?

2024-10-09_174633
2024-10-09_175613

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.44%. Comparing base (c2c2f4b) to head (fb4b93d).
Report is 61 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5017      +/-   ##
============================================
- Coverage     10.46%   10.44%   -0.03%     
+ Complexity     6022     6015       -7     
============================================
  Files           950      950              
  Lines        133437   133511      +74     
  Branches      19383    19400      +17     
============================================
- Hits          13967    13948      -19     
- Misses       118124   118217      +93     
  Partials       1346     1346              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS
Copy link
Member

This has picked up conflicts.

@IllianiCBT
Copy link
Collaborator

Just a thought while you fix these conflicts, it might be useful to have fatigue displayed in the TO&E, too.

You'll want something that looks like this:

if ((campaign.getCampaignOptions().isUseFatigue()) && (person.getEffectiveFatigue(campaign) > 0)) {
        int effectiveFatigue = person.getEffectiveFatigue(campaign);
        ++ colored text code ++
}

@WeaverThree
Copy link
Contributor Author

Not sure why that was a conflict, it was in a separate part of the file.

2024-10-11_090345

It doesn't look great unless you expand the panel, but then, neither do their names.

@IllianiCBT
Copy link
Collaborator

IllianiCBT commented Oct 11, 2024

Could we perhaps arrange it so that its...

Name
Veterancy and Role
Injuries/Hits and Fatigue

...I don't know if that would look better.

@WeaverThree
Copy link
Contributor Author

Now it's like this:

2024-10-11_101241

@HammerGS
Copy link
Member

Now it's like this:

2024-10-11_101241

I prefer this.

@IllianiCBT
Copy link
Collaborator

LGTM

@IllianiCBT IllianiCBT merged commit bfff557 into MegaMek:master Oct 11, 2024
4 checks passed
@WeaverThree WeaverThree deleted the wvr-advmed-injuries-ui branch October 16, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants