Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not merge #30113

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

do not merge #30113

wants to merge 8 commits into from

Conversation

ParkMyCar
Copy link
Member

Putting up the CatalogItemId change to run against CI

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar
start, add CatalogItemId type
4712ac8 
* adds a new enum CatalogItemId to the mz_repr crate
* add protobuf representation for CatalogItemId
@ParkMyCar
bump catalog version, add migration
cbf49ee 
* bumps the catalog version from v67 to v68
* migrates uses of GlobalId in the catalog to CatalogItemID
* adds 'global_id' and 'extra_versions' field to ItemValue for ALTER TABLE
* everything else required for a catalog migration
@ParkMyCar
boilerplate, essentially find and replace GlobalId with CatalogItemId
c607961
@ParkMyCar
associate a GlobalId with every CatalogItemId
fff656c 
* add Catalog APIs for getting an item via GlobalId vs CatalogItemId
* update the Catalog and Adapter to primarily use CatalogItemId, falling back to GlobalId when necessary
@ParkMyCar
builtin item migrations
7409cee
@ParkMyCar
fix issue with how we refer to ingestions of Tables
321c09b
@ParkMyCar
update consistency checks
e0fdcea
@ParkMyCar
bin/fmt
c907489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch Awaiting requested review from benesch benesch will be requested when the pull request is marked ready for review benesch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ParkMyCar