Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for client tls #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neilblue
Copy link

Updated library to use new httpclient keystore support

@Hi-Fi
Copy link
Collaborator

Hi-Fi commented Jun 27, 2017

Snapshot version not working according automated tests, so some work still needed. I think httpclient itself might be OK.

Results:

Get HTTPS & Verify Cert                                               | FAIL |
IO exception. Message: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
------------------------------------------------------------------------------
Get HTTPS & Verify Cert with a CA bundle                              | FAIL |
IO exception. Message: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
------------------------------------------------------------------------------
Get With Auth                                                         | FAIL |
IO exception. Message: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

@Hi-Fi
Copy link
Collaborator

Hi-Fi commented Jul 8, 2017

Please add support for Snapshots to POM-file, so Travis build can test that things work.

New version of httpclient is working with library, so fix is just for Travis (and developers).

<repositories>
	<repository>
		<id>snapshots-repo</id>
		<url>https://oss.sonatype.org/content/repositories/snapshots</url>
		<releases>
			<enabled>false</enabled>
		</releases>
		<snapshots>
			<enabled>true</enabled>
		</snapshots>
	</repository>
</repositories>

@Hi-Fi
Copy link
Collaborator

Hi-Fi commented Jul 10, 2017

It's not compiling, as some changes are introduced to httpclient because of proxy support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants