do not pass mariadbd arguments with whitespace to mariadb-install-db #575
Conversation
| if [[ ! "$arg" =~ [[:space:]] ]]; then | ||
| mariadbdArgs+=("$arg") | ||
| else | ||
| mysql_warn Not passing argument \'$arg\' to mariadb-install-db because mariadb-install-db does not support arguments with whitespace. |
There was a problem hiding this comment.
Should this be warning or error? Warnings could be silently ignored in the automation and lead to potential failures.
There was a problem hiding this comment.
Not sure if you are asking me ...
... but I would agree with you.
There was a problem hiding this comment.
I consider an error as something that cannot proceed and a warning is something that might be impacting. As the original example showed there are some things that make little difference to the way mariadb-install-db processes.
Regardless I'm hoping that this is only a temporary change until the server implementation is made cleaner with some actual shell programming expertise.
There was a problem hiding this comment.
LGTM but I would rewrite the if:
if [[ "$arg" =~ [[:space:]] ]]; then
warning
else
OK
fiseems much more simple to understand.
grooverdan
force-pushed
the
init-connect-fix
branch
from
8ef2bab
to
64c51e4
Compare
| # Check if the argument contains whitespace | ||
| if [[ ! "$arg" =~ [[:space:]] ]]; then | ||
| mariadbdArgs+=("$arg") | ||
| else |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Workaround for issue #574