fix: Correctly deserialize GitLab MR commits #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response for `/api/v4/projects/:id/merge_requests/:merge_request_iid/commits` is described [in the documentation], and includes neither a `sha`, nor an `author` field. [in the documentation]: https://docs.gitlab.com/ee/api/merge_requests.html#get-single-merge-request-commits
MarcoIeni
approved these changes
Oct 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response for
/api/v4/projects/:id/merge_requests/:merge_request_iid/commitsis described in the documentation, and includes neither asha, nor anauthorfield.As far as I can tell the
GitLabMrCommitis only parsed from the/api/v4/projects/:id/merge_requests/:merge_request_iid/commitsroute, so the fields that are parsed have to be adjusted.I removed the author information, because the route described only gives
{author,committer}_name, and{author,committer}_email, which are taken from the commit, and do not correlate to GitLab usernames. If it is fine to use the commit author name in place of the username, I can add it back in (I am not familiar with the rest of the codebase and do not know if using a "wrong" username would have any impact).