Remove newlines from error message #23215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
better_error_messages
branch
from
d1502c4
to
7c8f11b
Compare
Newlines can cause trouble with translations as well as presentation in the UI. This particular string doesn't actually need the newline as part of the translation string, so this commit changes it to just not have it. Alternative to ManageIQ#23213
Fryguy
force-pushed
the
better_error_messages
branch
from
7c8f11b
to
8d24399
Compare
|
Checked commit Fryguy@8d24399 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
jrafanie
reviewed
Oct 1, 2024
| err_text = "Provision failed for the following reasons:\n#{errors.join("\n")}" | ||
| _log.error("<#{err_text}>") | ||
| raise _("Provision failed for the following reasons:\n%{errors}") % {:errors => errors.join("\n")} | ||
| err_text = errors.join("\n").insert(0, "\n") |
There was a problem hiding this comment.
Note, the newline might cause issues if translators don't embed it in their translations.
See: #23218 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newlines can cause trouble with translations as well as presentation in the UI. This particular string doesn't actually need the newline as part of the translation string, so this commit changes it to just not have it.
Alternative to #23213
@jrafanie Please review.