[BO - Carto] Fix sur un bug de calcul de statut #815
+113
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfinx13
reviewed
Oct 28, 2024
Comment on lines
+26
to
+29
| $swLat = $request->get('swLat'); | ||
| $swLng = $request->get('swLng'); | ||
| $neLat = $request->get('neLat'); | ||
| $neLng = $request->get('neLng'); |
There was a problem hiding this comment.
Faudrait mapper un DTO avec controles des données en entrée
https://symfony.com/blog/new-in-symfony-6-3-mapping-request-data-to-typed-objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#810
Description
Il y avait un bug sur le calcul du statut resolved pour les signalements créés il y a plus de 4 mois, le statut n'était calculé que pour les signalements de territoires fermés, or il n'y a plus de territoires fermés
Mais pour identifier la cause du bug, j'ai fait une refacto pour ne charger les signalements que pour la zone de la carte affichée à l'écran (et pas pour les 9000 max signalements)
Changements apportés
Pré-requis
npm run buildTests