Add database auditability #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jmaupetit
commented
Oct 15, 2024
jmaupetit
commented
Oct 15, 2024
jmaupetit
force-pushed
the
add-audit-feature
branch
from
ec221f1
to
3ec1c2d
Compare
jmaupetit
commented
Oct 18, 2024
| ) | ||
| ).one() | ||
| assert pdc7.paiement_cb | ||
| assert len(pdc7.audits) == 1 |
There was a problem hiding this comment.
Maybe it fails because when listening the "after_update" event in an upsert context, the event is never raised on "conflict do update"?
There was a problem hiding this comment.
Maybe we should create a custom event?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need to be able to track who changed what when on most of our data for auditability purpose.
Proposal
created_by_idandupdated_by_idfields in auditable modelstrack_model_changesutility that can be triggered upon SQLAlchemy events