[Carte] Normalise la position des menus #3131

ivangabriele · 2024-04-23T20:16:54Z

Linked issues

Préavis – Consulter la liste des préavis #2843

Tests E2E (Cypress)

louptheron · 2024-04-24T05:34:22Z

frontend/src/features/MainWindow/components/LeftMenu.tsx

+
+import { mainWindowActions } from '../slice'
+
+export function LeftMenu() {


Suggested change

export function LeftMenu() {

export function LeftMapMenu() {

?

louptheron · 2024-04-24T05:34:42Z

frontend/src/features/MainWindow/components/LeftMenu.tsx

+  const missionButtonRef = useRef<HTMLDivElement | null>(null)
+
+  const dispatch = useMainAppDispatch()
+  const { favorites } = useMainAppSelector(state => state.favoriteVessel)


Suggested change

const { favorites } = useMainAppSelector(state => state.favoriteVessel)

const favorites = useMainAppSelector(state => state.favoriteVessel.favorites)

?

louptheron · 2024-04-24T05:40:11Z

frontend/src/features/MainWindow/components/LeftMenu.tsx

+        )}
+
+        {import.meta.env.FRONTEND_PRIOR_NOTIFICATION_LIST_ENABLED === 'true' && (
+          <IconButton Icon={Icon.Fishery} size={Size.LARGE} />


Il manque d'ailleurs ce bouton dans le slice displayedComponent

louptheron · 2024-04-24T05:42:21Z

frontend/src/features/MainWindow/components/LeftMenu.tsx

+  left: 112px;
+  top: 12px;
+
+  * {


Il faudra qu'on arrive à enlever ce style car on est obligé de l'injecter dans beaucoup de composants enfants :/

Alors l'idée c'est de finir par le mettre en global plutôt comme c'est le standard pour grandement facilement les calculs de tailles en séparant l'espace intérieur de l'espace extérieur.

Tout est construit sur cette base sur monitor-ui,

rapport-nav l'a en global : https://github.com/MTES-MCT/rapportnav2/blob/main/frontend/src/assets/css/index.css,

et Rsuite d'ailleurs aussi : https://github.com/rsuite/rsuite/blob/main/src/styles/normalize.less

Du coup je suis d'accord mais dans le sens où une fois tout migré, on l'aura en global via rsuite et on pourra le retirer partout ailleurs.

Au passage cette PR fixe pas mal de soucis visuels en prod, sur les dialogs/overlays des contacts par exemple.

Oui c'est ce que je voulais dire pour le passage en global et le fait de l'enlever dans les composants enfants

louptheron · 2024-04-24T05:43:45Z

frontend/src/features/MainWindow/components/LeftMenu.tsx

+      {isFavoriteVesselsMapButtonDisplayed && (
+        <Block>
+          <IconButtonWrapper>
+            <IconButtonBadge $isActive={leftDialog?.key === 'FAVORITE_VESSELS'}>


il manque un onClick ?

In progress, mais oui en effet.

louptheron · 2024-04-24T05:51:32Z

frontend/src/features/Mission/components/MissionMenuDialog.tsx

+  }
+
+  return (
+    <Wrapper data-cy="missions-menu-box" style={{ top: leftDialog?.topPosition }}>


Je ne vois pas où est l'animation sur l'ouverture ?

louptheron · 2024-04-24T05:52:43Z

frontend/src/features/Mission/components/MissionMenuDialog.tsx

+import { sideWindowActions } from '../../../domain/shared_slices/SideWindow'
+import { mainWindowActions } from '../../MainWindow/slice'
+
+export function MissionMenuDialog() {


ça me va d'utiliser Dialog

louptheron · 2024-04-24T05:54:40Z

frontend/src/features/Reporting/useCases/addReporting.ts

@@ -11,6 +13,15 @@ export const addReporting =
  (newReporting: ReportingCreation): MainAppThunk<Promise<void>> =>
  (dispatch, getState) => {
    const { selectedVesselIdentity } = getState().vessel
+    // TODO Can this case happen? Is it the right way to handle it?


Je ne vois pas comment, car un signalement s'ajoute quand la fiche navire est ouverte (on a donc un selectedVesselIdentity).
Autant mettre un assert je pense

louptheron · 2024-04-24T05:55:03Z

frontend/src/features/Reporting/useCases/deleteReporting.ts

  (dispatch, getState) => {
    const { selectedVesselIdentity } = getState().vessel
+    // TODO Can this case happen? Is it the right way to handle it?


louptheron · 2024-04-24T05:56:14Z

frontend/src/features/VesselSidebar/VesselSidebarHeader/VesselName.tsx

@@ -29,6 +30,15 @@ export function VesselName({ focusOnVesselSearchInput }) {
  const addOrRemoveToFavorites = useCallback(
    e => {
      e.stopPropagation()
+      // TODO Can this case happen? Is it the right way to handle it?


Same, n'est possible que dans la fiche navire est ouverte

…ROPOSAL]

…te vessel callback

…onentState

sonarcloud · 2024-05-13T05:45:41Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

louptheron · 2024-09-26T08:29:46Z

Repris ici : #3634

ivangabriele force-pushed the ivan/normalize-map-menu-margins branch 3 times, most recently from a7574b3 to 3e30ef4 Compare April 23, 2024 21:25

louptheron reviewed Apr 24, 2024

View reviewed changes

ivangabriele added 10 commits May 2, 2024 10:48

Create LeftMenu & migrate global slice into MainWindow feature [WIP/P…

750b73e

…ROPOSAL]

Replace soft error logs by assertions in reporting use cases & favori…

67b7cf8

…te vessel callback

Rename leftDialog to openedLeftDialog in MainWindowState

56d3069

Add isPriorNotificationsLeftMenuButtonDisplayed prop to DisplayedComp…

ae4d24c

…onentState

Add restorable main window components display state

08c2709

Simplify MapComponents component

9d6a1bc

Use all main window comps hide/restore in filtered vessel list preview

68d67fb

Move favorite vessel list dialog to main window left menu

92386c0

Move regulations dialog to main window left menu

c47a203

Set main window left menu left+top position to 12px

eb25491

ivangabriele force-pushed the ivan/normalize-map-menu-margins branch from 3e30ef4 to eb25491 Compare May 13, 2024 05:44

ivangabriele mentioned this pull request Sep 10, 2024

Alertes – Corrige la sélection de façade lorsque l'on ouvre une alerte à partir de la fiche navire #3631

Merged

1 task

ivangabriele added the tech. enhancement technical ehancement label Sep 11, 2024

louptheron closed this Sep 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Carte] Normalise la position des menus #3131

[Carte] Normalise la position des menus #3131

ivangabriele commented Apr 23, 2024

louptheron Apr 24, 2024

louptheron Apr 24, 2024

louptheron Apr 24, 2024

ivangabriele Apr 25, 2024

louptheron Apr 24, 2024

ivangabriele Apr 25, 2024 •

edited

Loading

louptheron Apr 25, 2024

louptheron Apr 24, 2024

ivangabriele Apr 25, 2024

louptheron Apr 24, 2024

louptheron Apr 24, 2024

louptheron Apr 24, 2024

louptheron Apr 24, 2024

louptheron Apr 24, 2024

sonarcloud bot commented May 13, 2024

louptheron commented Sep 26, 2024


		import { mainWindowActions } from '../slice'

		export function LeftMenu() {

	const { favorites } = useMainAppSelector(state => state.favoriteVessel)
	const favorites = useMainAppSelector(state => state.favoriteVessel.favorites)

[Carte] Normalise la position des menus #3131

[Carte] Normalise la position des menus #3131

Conversation

ivangabriele commented Apr 23, 2024

Linked issues

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivangabriele Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented May 13, 2024

Quality Gate passed

louptheron commented Sep 26, 2024

ivangabriele Apr 25, 2024 •

edited

Loading