-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BO - Export] Remplacer la pièce jointe de l'export par un lien téléchargeable en corps de mail #3114
Conversation
Quality Gate failedFailed conditions |
|
||
public function up(Schema $schema): void | ||
{ | ||
$this->addSql('ALTER TABLE file CHANGE signalement_id signalement_id INT DEFAULT NULL'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai du enregistrer l'export dans la table file pour le rendre téléchargeable.
Faudra envisager un nettoyage par la suite
Aussi se reposer la question d'une table file agnostique de toutes données métiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t'as créé un ticket de nettoyage pour plus tard ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done #3127
if (DocumentType::EXPORT === $documentType) { | ||
return (new BinaryFileResponse($file))->setContentDisposition( | ||
ResponseHeaderBag::DISPOSITION_INLINE, | ||
$file->getFilename() | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour éviter la régression sur le nom de fichier d'export
@@ -24,6 +24,7 @@ enum DocumentType: String | |||
case AUTRE_PROCEDURE = 'AUTRE_PROCEDURE'; | |||
case PHOTO_SITUATION = 'PHOTO_SITUATION'; | |||
case PHOTO_VISITE = 'PHOTO_VISITE'; | |||
case EXPORT = 'EXPORT'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La purge pourra s'appuyer sur ce champ
$uuid = Uuid::v4(); | ||
$filename = 'export-histologe-'.$listExportMessage->getUserId().'-'.$datetimeStr.'-'.$uuid.'.'.$format; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rendre le nom de fichier moins prévisible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relecture et tests OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK lecture et tests
Ticket
#3111
Description
Contrainte de poids des fichiers pour les pièces jointes : Remplacer la pièce jointe par un lien de téléchargement.
Changements apportés
Pré-requis
Tests