[BO - Export] Remplacer la pièce jointe de l'export par un lien téléchargeable en corps de mail #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sfinx13
commented
Oct 1, 2024
|
|
||
| public function up(Schema $schema): void | ||
| { | ||
| $this->addSql('ALTER TABLE file CHANGE signalement_id signalement_id INT DEFAULT NULL'); |
There was a problem hiding this comment.
J'ai du enregistrer l'export dans la table file pour le rendre téléchargeable.
Faudra envisager un nettoyage par la suite
Aussi se reposer la question d'une table file agnostique de toutes données métiers
There was a problem hiding this comment.
t'as créé un ticket de nettoyage pour plus tard ?
Comment on lines
+46
to
+51
| if (DocumentType::EXPORT === $documentType) { | ||
| return (new BinaryFileResponse($file))->setContentDisposition( | ||
| ResponseHeaderBag::DISPOSITION_INLINE, | ||
| $file->getFilename() | ||
| ); | ||
| } |
There was a problem hiding this comment.
Pour éviter la régression sur le nom de fichier d'export
| @@ -24,6 +24,7 @@ enum DocumentType: String | |||
| case AUTRE_PROCEDURE = 'AUTRE_PROCEDURE'; | |||
| case PHOTO_SITUATION = 'PHOTO_SITUATION'; | |||
| case PHOTO_VISITE = 'PHOTO_VISITE'; | |||
| case EXPORT = 'EXPORT'; | |||
There was a problem hiding this comment.
La purge pourra s'appuyer sur ce champ
Comment on lines
+54
to
+55
| $uuid = Uuid::v4(); | ||
| $filename = 'export-histologe-'.$listExportMessage->getUserId().'-'.$datetimeStr.'-'.$uuid.'.'.$format; |
There was a problem hiding this comment.
Rendre le nom de fichier moins prévisible
hmeneuvrier
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#3111
Description
Contrainte de poids des fichiers pour les pièces jointes : Remplacer la pièce jointe par un lien de téléchargement.
Changements apportés
Pré-requis
Tests