Carto : retravaille la popup #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
feat/new-map-popup
branch
3 times, most recently
from
357168f
to
acc5d6d
Compare
florimondmanca
commented
Sep 26, 2024
There was a problem hiding this comment.
Petit refacto, on répétait ça à plusieurs endroits alors qu'on avait déjà factorisé l'affichage des périodes etc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
=========================================
Coverage 99.07% 99.07%
- Complexity 1630 1633 +3
=========================================
Files 316 316
Lines 7009 7017 +8
=========================================
+ Hits 6944 6952 +8
Misses 65 65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
florimondmanca
force-pushed
the
feat/new-map-popup
branch
from
acc5d6d
to
526dd3b
Compare
florimondmanca
force-pushed
the
feat/new-map-popup
branch
from
526dd3b
to
51d6828
Compare
Lealefoulon
approved these changes
Sep 30, 2024
|
Merci @Lealefoulon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR aligne la popup de la carte sur la maquette