This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Modify ocean core barotropic subcycle to reuse halo data structure #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the subcycle halo exchanges of sshSubcycle and normalBarotropicVelocitySubcycle to follow the alternative framework routines which reuse the halo exchange group data structure.
Speed tested on 256 Cori KNL nodes with 8448 mpi ranks, 4 threads per rank, mid resolution mesh, and ~170 cells per rank, the performance gain is 25%.
There is also a cleanup of the tracking of remaining valid halo cells and edges as the subcycle progresses; this removes the extra exchange edge case, and allows correct behavior for config_num_halos != 3 (although using a halo size other than 3 diminishes performance).