ci(parallel): skip test_par_gwf02 cases d-f, no xdist on windows #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakmerol
approved these changes
Jul 23, 2024
|
Parallel build failed the serial tests on Windows CI for some reason, @mjr-deltares could not reproduce locally. Will merge so this speeds things up for now and come back to the CI failure |
4 tasks
wpbonelli
added a commit
that referenced
this pull request
Jul 26, 2024
Follow up on #1960. Run the serial tests to make sure the parallel build doesn't break any serial functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the slowest parallel test cases on Windows CI. Also don't use xdist to avoid unwanted oversubscription (though we deliberately oversubscribe in the test cases themselves).
TODO: re-enable all autotests for parallel test job, rather than only parallel tests, since we want to make sure the parallel build doesn't regress any serial functionality.
xref actions/runner-images#7320 where many others have reported inexplicably slow Windows runners
Checklist of items for pull request