Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI #36

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Update CI #36

merged 6 commits into from
Apr 29, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Apr 28, 2024

Fixes #34

Changes made in this Pull Request:

  • Fix CI, dropping 3.9 testing

TODO

  • Update packaging to reflect 3.10+

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay requested a review from orbeckst April 28, 2024 20:53
@codecov Codecov
Copy link

codecov bot commented Apr 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (0507469) to head (90d021e).

Additional details and impacted files

orbeckst
orbeckst approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Perhaps add a comment for future maintainers.

.github/workflows/gh-ci.yaml Outdated
Comment on lines 35 to 37
exclude:
- python-version: "3.12"
mdanalysis-version: "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly add comment here to tell future maintainers how to handle "latest" and highest Python versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@IAlibay IAlibay mentioned this pull request Apr 29, 2024
Open
@IAlibay
Copy link
Member Author

IAlibay commented Apr 29, 2024

Thanks for the review @orbeckst!

@IAlibay IAlibay merged commit a30f466 into main Apr 29, 2024
20 checks passed
@IAlibay IAlibay deleted the fix-ci branch April 29, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails for Python 3.9
2 participants
@IAlibay @orbeckst