-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI.yaml for Py3.12 and drop Py3.8 #98
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9452806
Update CI.yaml for Py3.12 and drop Py3.8
hmacdope 284e66d
Update CI.yaml
hmacdope 1c70d80
Update CI.yaml
hmacdope aff81d2
Update CI.yaml
hmacdope 48bb14a
Update pyproject.toml
hmacdope 2190e20
Update requirements.txt
hmacdope 6368287
Update test_env.yaml
hmacdope 9864438
Update pyproject.toml
hmacdope c1ac99f
Update test_env.yaml
hmacdope f53f149
pinned pandas to 2.2 because pandas=2.1 causes a mysterious error in …
orionarcher f2794c8
build failing on GitHub, add explicit install of sphinx_rtd_theme to …
orionarcher 56f7d62
add pin to test_env.yaml
orionarcher d2569f0
fix typo in pin to test_env.yaml
orionarcher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ dependencies: | |
| - nbsphinx | ||
| - ipython | ||
| - plotly | ||
| - sphinx_rtd_theme | ||
|
|
||
|
|
||
| # Pip-only installs | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| setuptools | ||
| numpy>=1.20.0 | ||
| pandas<2.1 | ||
| pandas>=2.2 | ||
| mdanalysis>=2.0.0 | ||
| pytest | ||
| pathlib | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh setuptools as a runtime dependency is really rare - what are you using it for? Usually it goes under build time dependencies.
P.S. if you drop versioneer you could drop setup.py completely I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using
pkg_resourcesin python 3.12 has an explicit dependency on setuptools now. IIRC there is a replacement but I was too lazy to search it out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always mess up the
versioningitsetup for some reason.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah - I'd drop
pkg_resources, best thing is to use importlib. Here's the giant MDA example 😅 : https://github.com/MDAnalysis/mdanalysis/blob/develop/testsuite/MDAnalysisTests/datafiles.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: versioningit setup - here's the recent change we did for waterdynamics, hopefully should give you all the things that need changing: https://github.com/MDAnalysis/waterdynamics/pull/28/files