Add deploy workflow - no tests due to hole2 dep #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbeckst
previously requested changes
Jan 14, 2024
There was a problem hiding this comment.
Thanks. Generally looks good but I am blocking this until we have converged on a name #47 .
@lilyminium , as the current person in charge, feel free to dismiss my review at any point.
lilyminium
approved these changes
Jan 16, 2024
lilyminium
dismissed
orbeckst’s stale review
Dismissing as suggested -- thanks Oliver!
|
@lilyminium I didn't put down an expected publisher on pypi/testpypi, so that'll need to happen before a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickly adding this here since I did the same for membrane-curvature