Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard autodeployment (#57) #63

Merged
merged 3 commits into from
Oct 30, 2023
Merged

add standard autodeployment (#57) #63

merged 3 commits into from
Oct 30, 2023

Conversation

orbeckst
Copy link
Member

fix #57

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (657d2b6) 56.06% compared to head (7a0ffe2) 56.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files          12       12           
  Lines         371      371           
  Branches       51       51           
=======================================
  Hits          208      208           
  Misses        160      160           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orbeckst
Copy link
Member Author

THis is still token based. Let me look into trusted publisher-based.

@IAlibay
Copy link
Member

IAlibay commented Oct 29, 2023

@orbeckst easiest is probably to merge my griddataformats PR and then copy that?

- trusted PyPi published configured
- removed TOKEN-based authentication
  (note: repo had never any secrets defined)
@orbeckst
Copy link
Member Author

Will look at the other PR then... wasn't aware.

I did enable Trusted Publisher on PyPi. Still to do on testpypi, come to think.

@orbeckst
Copy link
Member Author

For my own reference: MDAnalysis/GridDataFormats#136

(will update later tonight)

- update deploy.yaml with @IAlibay's updates in GridDataFormats
- added 'deploy' environment in MDAnalysisData settings
- updated Trusted Publisher for PyPi project
- added pending Trusted Publisher (https://docs.pypi.org/trusted-publishers/) for Test PyPi
  project
@orbeckst
Copy link
Member Author

On testpypi I set up a pending publisher : Hopefully the first test will correctly create the test pypi project.

@orbeckst orbeckst requested a review from IAlibay October 30, 2023 15:06
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@orbeckst
Copy link
Member Author

I raised #65 for the RTD failure. But I'll merge this one.

@orbeckst orbeckst merged commit c550a46 into master Oct 30, 2023
10 of 11 checks passed
@orbeckst orbeckst deleted the autodeploy branch October 30, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate deployment
2 participants