-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add standard autodeployment (#57) #63
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 56.06% 56.06%
=======================================
Files 12 12
Lines 371 371
Branches 51 51
=======================================
Hits 208 208
Misses 160 160
Partials 3 3 ☔ View full report in Codecov by Sentry. |
THis is still token based. Let me look into trusted publisher-based. |
@orbeckst easiest is probably to merge my griddataformats PR and then copy that? |
- trusted PyPi published configured - removed TOKEN-based authentication (note: repo had never any secrets defined)
Will look at the other PR then... wasn't aware. I did enable Trusted Publisher on PyPi. Still to do on testpypi, come to think. |
For my own reference: MDAnalysis/GridDataFormats#136 (will update later tonight) |
- update deploy.yaml with @IAlibay's updates in GridDataFormats - added 'deploy' environment in MDAnalysisData settings - updated Trusted Publisher for PyPi project - added pending Trusted Publisher (https://docs.pypi.org/trusted-publishers/) for Test PyPi project
On testpypi I set up a pending publisher : Hopefully the first test will correctly create the test pypi project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I raised #65 for the RTD failure. But I'll merge this one. |
fix #57