Refactor guild roster display logic and fix img attribute #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a conditional check to show a loading message if `GuildRosterData` is null or empty. Moved the `foreach` loop inside an `else` block to execute only when `GuildRosterData` has members. Retained nested `if` conditions and HTML structure within the `else` block. Corrected the placement of `crossorigin="anonymous"` attribute to the appropriate `img` tag. Removed redundant `else` block for `CharacterMedias` check, simplifying the code.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-smoke-0d5c5b110-8.centralus.5.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a conditional check to show a loading message if
GuildRosterDatais null or empty. Moved theforeachloop inside anelseblock to execute only whenGuildRosterDatahas members. Retained nestedifconditions and HTML structure within theelseblock. Corrected the placement ofcrossorigin="anonymous"attribute to the appropriateimgtag. Removed redundantelseblock forCharacterMediascheck, simplifying the code.