Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant auth check query #2572

Open
wants to merge 2 commits into
base: v6
Choose a base branch
from
Open

Remove redundant auth check query #2572

wants to merge 2 commits into from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 19, 2024 •
edited
Loading

Subscribing on LycheeStore was making the request being fired every time the lycheStore changed... definitely not optimal. We only want to reload the data when the user change. So better to just watch the reactive reference to user.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Oct 19, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (a293683) to head (fbf22ba).

Additional details and impacted files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ildyria