WIP v6

[ildyria]

Fixes #106
Closes #126
Fixes #226 (SE)
Closes #520 (SE)
Fixes #987
Fixes #1420
Closes #1641 (SE)
Fixes #1987
Fixes #2082
Fixes #2086
Fixes #2168
Fixes #2194
Fixes #2361
Fixes #2495

[tinohager]

Is there already a time horizon for completion :) ?

[ildyria]

I wish. :')

I have a PR here to create a small blog:
LycheeOrg/LycheeOrg.github.io#132

waiting for reviews. :)
The blog aims to provide some highlight of the work in progress on V6.

[tinohager]

The site looks nice. The main menu item "Docs" has no content yet. If I understand correctly, this project will also replace the current project website?

[ildyria]

No, just an update/refresher of the LycheeOrg website, nothing much there.
The make command build the full thing in dist (including the docs ;) ).

[ildyria]

Yeah I need to redo a lot of the translations. :(

[tinohager]

"Upload track"

what should the button say at first glance I do not recognize what exactly the meaning of this button is

[ildyria]

"Upload track"

what should the button say at first glance I do not recognize what exactly the meaning of this button is

If you have gps data, you can upload a track xml data and that one will be displayed on the map in addition to the pictures.

[tinohager]

"Upload track"
what should the button say at first glance I do not recognize what exactly the meaning of this button is

If you have gps data, you can upload a track xml data and that one will be displayed on the map in addition to the pictures.

this is probably not a likely function for a standard user. I would direct this to a separate dialog where it is better described.

[codecov]

Codecov Report

Attention: Patch coverage is 71.82663% with 364 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (02e5a20) to head (a293683).
Report is 96 commits behind head on master.

Additional details and impacted files

[ildyria]

I deem this ready for review. I will not be adding anything on top on the PR because @d7415 still needs to review it, and this needs stability. :)

[tinohager]

Too bad then I won't report anything more 😆 🤣

[tinohager]

@ildyria Does it make sense to continue using the non-vuejs frontend with V6? That increases the support effort. And I don't see any advantage in that. We already have two different frontends, and the new frontend has improvements that have not been incorporated into the existing one.

[ildyria]

@ildyria Does it make sense to continue using the non-vuejs frontend with V6?

It is only there as a backup solution in case something very much goes wrong (e.g. at the moment hosting on sub folder).

That increases the support effort.

Not at all. :D

1. I completely decoupled the API used by the v4 front-end from the API that use the v6.
2. The api using the v4 is frozen as is and not going to change.
3. The v1 api is never going to be used in the v6.
4. The Lychee-front repo which contains the v4 is set to read-only.

Also I actually made the following script: https://github.com/LycheeOrg/Lychee/blob/v6/scripts/delete_legacy.sh
which is supposed to nuke anything related to v4 and the previous front-end. :)

And I don't see any advantage in that. We already have two different frontends, and the new frontend has improvements that have not been incorporated into the existing one.

I agree there are not big advantage, but I would say it is really just a fallback solution in case something really does not works. I have to admit was very very useful when rolling out the v5 and when Livewire was failing in so many cases.
Once I am 100% sure that the Vue Front-end is working for everyone, I will have no problem with removing the v4 and all Legacy crap. :)

[tinohager]

I've already done some tests with the new Vue frontend and I'm really looking forward to it. I think this is the right way to go.

[tinohager]

I've already reviewed the code a bit, but my browser is getting confused with the huge pull request from V6.

[ildyria]

I've already done some tests with the new Vue frontend and I'm really looking forward to it. I think this is the right way to go.

Agreed. :)