Seekbar controls feature #72
Conversation
[+] Install unmet peer deps [+] babel/core, babel preset env, types rn 0.63.17
[+] Remove types/react-native
[+] Would like to add progress indicators 1x 2x 3x etc [+] Need to change the first press to just jump forward 15 sec once
[+] Clean up console logs [+] Add button controls for skips [+] Add images for skip button
[+] Code Clean up
|
@LunatiqueCoder The last commit will be necessary to try it out. I had also forgotten to remove an import so it will break without last commit. :) |
|
Ok, I'll try to have a look this weekend. Really happy that you mananged to sort it out! |
|
Me too! Thank you! :)
…On Fri, Aug 11, 2023, 12:18 AM Ovidiu Cristescu ***@***.***> wrote:
Ok, I'll *try* to have a look this weekend. Really happy that you
mananged to sort it out!
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIVRSFAOVREJOK3OWEMJUODXUW6CRANCNFSM6AAAAAA3JBIQFI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
[+] added white icons [+] renamed seek icons to more meaningful names [+] removed rewind style
[+] removed black icons
|
@esegebart Ok, this looks good actually, but of course it can be improved. And It just came to my mind a very good idea. Although I have 1 question: Do you plan to have both type of buttons for your project? Or do you want to keep the ones you created only? Because I think that #37 will enable you to extract your logic outside of the package and pass it as props (onPressRewind, icon, etc), meaning that everyone will be able to customise to an extended level. |
|
@LunatiqueCoder Hey! I'm so glad you like it 🤩 So in my case, yes, I will be using both. Some of my broadcasts are 12 hours long so I need to be able to allow the user to get to a game that starts at 8 hours in quickly, while also letting them go back 15 seconds to rewatch a play made by a player. In the future, this my not be necessary because the cameras will know when a new game starts. But I was just trying to figure out how to separate those concerns between skipping and rewind/fast forwarding. And voila! Two buttons :) Did you try the continuous rewind/FF up to 4x? I actually discovered how to do it by accident. 😂 It would be nice to have a little indicator how fast they are at but yeah! Super glad to hear it looks good! Of course yes it can improve, the onEnd needs to happen when it reaches the end of the video while rewind/FF, the icons could be a little crisper, indicator of rw/FF speed on buttons, code a little cleaner. Overall, I am so proud of the progress I've made in the last few months that was able to make this actually do what I wanted! :) Skillz improving 🤩 |
[+] Rename the icon file to use 3x [+] Styling of icons to make them even
…rt/react-native-media-console into seekbar-controls-feature
[+] Props had a B instead of a b in it [+] Update all disableSeekBar
[+] Remove the equal sign from rw ff
|
Hey @esegebart. Does this work on your side? I tried it on iOS and it's going a little bit crazy 🥲 |
|
I haven't tested it in a while. I will have to check it out and get back to
you!
…On Thu, Sep 21, 2023, 1:59 PM Ovidiu Cristescu ***@***.***> wrote:
Hey @esegebart <https://github.com/esegebart>. Does this work on your
side? I tried it on iOS and it's going a little bit crazy 🥲
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIVRSFFBK22TCG3YJC5DXLDX3SFBXANCNFSM6AAAAAA3JBIQFI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@esegebart I'm so sorry but the package changed so much lately, I am not sure that we can use those changes anymore. I think we should try again after we implement #37. I'll close this for now. |
Added skip forward and skip backward icons to move 15 seconds ahead or back.
Changed the rewind and fast forward buttons to continuously skip upon pressing. Each press increase the speed of rewind or fast forward up to 4X.